fix: reaction list shows blank entries when UI_Use_Real_Name is enabled - #41574
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f3121f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
|
| Layer / File(s) | Summary |
|---|---|
Broadcast reaction name resolution apps/meteor/server/lib/notifyListener.ts, .changeset/wet-turtles-fix.md |
Collects unique reaction usernames, fetches matching user names, rewrites reaction names with resolved names or username fallbacks, and records the patch release fix. |
Reaction mapping test coverage apps/meteor/tests/unit/server/lib/notifyListener.spec.ts |
Adds the bulk-user lookup stub and verifies reaction name resolution, deduplication, projections, and empty-reaction behavior. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested labels: type: bug
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately summarizes the main fix: reaction list entries were blank when UI_Use_Real_Name was enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Warning
Review ran into problems
🔥 Problems
Errors were encountered while retrieving linked issues.
Errors (1)
- NATIVE-1047: Request failed with status code 401
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
coderabbitai
Bot
added
the
type: feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/meteor/tests/unit/server/lib/notifyListener.spec.ts (1)
105-126: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winAssert the deduplicated bulk lookup contract.
This fixture has no repeated username, and the stub ignores its arguments, so regressions to duplicate or per-reaction lookups still pass. Add a repeated username and assert one
findByUsernamescall with unique usernames and{ projection: { username: 1, name: 1 } }.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/meteor/tests/unit/server/lib/notifyListener.spec.ts` around lines 105 - 126, Update the “useRealName” reaction fixture to repeat a username across reactions, then assert the real-name lookup invokes findByUsernames exactly once with the deduplicated usernames and projection { username: 1, name: 1 }. Ensure the stub verifies its arguments so duplicate or per-reaction lookups fail the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/meteor/tests/unit/server/lib/notifyListener.spec.ts`:
- Around line 105-126: Update the “useRealName” reaction fixture to repeat a
username across reactions, then assert the real-name lookup invokes
findByUsernames exactly once with the deduplicated usernames and projection {
username: 1, name: 1 }. Ensure the stub verifies its arguments so duplicate or
per-reaction lookups fail the test.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 66a43562-3f7f-441c-b327-a942d080d2e3
📒 Files selected for processing (2)
apps/meteor/server/lib/notifyListener.tsapps/meteor/tests/unit/server/lib/notifyListener.spec.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
- GitHub Check: ⚙️ Variables Setup
- GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/server/lib/notifyListener.tsapps/meteor/tests/unit/server/lib/notifyListener.spec.ts
**/*.spec.ts
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.spec.ts: Use descriptive test names that clearly communicate expected behavior in Playwright tests
Use.spec.tsextension for test files (e.g.,login.spec.ts)
Files:
apps/meteor/tests/unit/server/lib/notifyListener.spec.ts
🧠 Learnings (5)
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/server/lib/notifyListener.tsapps/meteor/tests/unit/server/lib/notifyListener.spec.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/server/lib/notifyListener.tsapps/meteor/tests/unit/server/lib/notifyListener.spec.ts
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/server/lib/notifyListener.tsapps/meteor/tests/unit/server/lib/notifyListener.spec.ts
📚 Learning: 2026-02-24T19:22:48.358Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/omnichannel/omnichannel-send-pdf-transcript.spec.ts:66-67
Timestamp: 2026-02-24T19:22:48.358Z
Learning: In Playwright end-to-end tests (e.g., under apps/meteor/tests/e2e/...), prefer locating elements by translated text (getByText) and ARIA roles (getByRole) over data-qa attributes. If translation values change, update the corresponding test locators accordingly. Never use data-qa locators. This guideline applies to all Playwright e2e test specs in the repository and helps keep tests robust to UI text changes and accessible semantics.
Applied to files:
apps/meteor/tests/unit/server/lib/notifyListener.spec.ts
📚 Learning: 2026-03-06T18:10:15.268Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 39397
File: packages/gazzodown/src/code/CodeBlock.spec.tsx:47-68
Timestamp: 2026-03-06T18:10:15.268Z
Learning: In tests (especially those using testing-library/dom/jsdom) for Rocket.Chat components, the HTML <code> element has an implicit ARIA role of 'code'. Therefore, screen.getByRole('code') or screen.findByRole('code') will locate <code> elements even without a role attribute. Do not flag findByRole('code') as invalid in reviews; prefer using the implicit role instead of adding role="code" unless necessary for accessibility.
Applied to files:
apps/meteor/tests/unit/server/lib/notifyListener.spec.ts
🔇 Additional comments (2)
apps/meteor/server/lib/notifyListener.ts (1)
471-478: LGTM!apps/meteor/tests/unit/server/lib/notifyListener.spec.ts (1)
9-9: LGTM!Also applies to: 33-33, 49-49, 212-227
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41574 +/- ##
===========================================
- Coverage 68.69% 68.68% -0.01%
===========================================
Files 4139 4139
Lines 159112 159278 +166
Branches 27917 27883 -34
===========================================
+ Hits 109300 109405 +105
- Misses 44666 44711 +45
- Partials 5146 5162 +16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Is it a regression related to the unicode emojis PR? The changeset says |
Rohit3523
changed the title
|
It is not a regression related to unicode emoji, and yeah i have update the title, Thanks |
Rohit3523
changed the title
coderabbitai
Bot
added
type: bug
and removed
type: feature
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
FragaKrummenauer
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
3 participants
Proposed changes
Resolves real names for message reactions in the broadcast pipeline. When
UI_Use_Real_Nameis enabled, the server now enriches each reaction with anamesarray containing the display names of users who reacted.Previously only the message author (
message.u.name) and mentions (mentions[].name) were resolved. This change extends the same pattern to reactions using a batch query (Users.findByUsernames) instead of per-username lookups.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1047
Steps to test or reproduce
Web
UI_Use_Real_Namein admin settingsMobile app
Note: Current behaviour differs by platform:
Further comments
Uses a single batch query (
Users.findByUsernames) to resolve all reaction usernames at once, deduplicated viaSet, with a fallback tousernamewhen a user has no display name set.Summary by CodeRabbit
Summary by CodeRabbit